Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new data augmentation module for time series, specifically frequency domain perturbation, and enhances the
WienerFilterSimulatorwith improved property management and testability. It also adds comprehensive unit tests for both the new augmentation functionality and the Wiener filter simulator. The package version is incremented to 0.0.8.New Features and Enhancements:
Data Augmentation:
augmentationmodule with afrequency_perturbationfunction for applying frequency domain perturbations to time series data, along with a helper functionsample_random_perturbation. This allows users to augment data for improved model robustness. (s2generator/augmentation/__init__.py,s2generator/augmentation/frequency_perturbation.py,s2generator/__init__.py) [1] [2] [3]tests/test_augmentation.py)Wiener Filter Simulator Improvements:
WienerFilterSimulatorclass to use a private attribute_sigma_sqfor noise variance, and added public getter propertysigma_sqfor safer access. (s2generator/simulator/wiener_filter.py) [1] [2] [3]set_coeffsandset_sigma_sqmethods to allow manual setting of filter coefficients and noise variance, facilitating easier testing and customization. (s2generator/simulator/wiener_filter.py)__all__for proper exports. (s2generator/simulator/__init__.py)WienerFilterSimulator, covering instantiation, fitting, transformation, property access, and manual parameter setting. (tests/test_wiener_filter_simulator.py)Other Changes:
Versioning:
s2generator/__init__.pyandsetup.pyto reflect new features and improvements. [1] [2]